Skip to content

Bugfix: Invalid comparison and assignment due to motor id's ranging from 1-6. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2022
Merged

Bugfix: Invalid comparison and assignment due to motor id's ranging from 1-6. #24

merged 2 commits into from
Jan 17, 2022

Conversation

aentinger
Copy link
Contributor

Fix: Motor IDs go from 1 to 6, but values are stored in arrays with a max size of 6.

This error was not observable while having configured for 7 motors (because '<' comparison was used) but is now obviously a problem.

@aentinger
Fix: Motor IDs go from 1 to 6, but values are stored in arrays with a…
e2f96f2 
… max size of 6.

This error was not observable while having configured for 7 motors (because '<' comparison was used) but is now obviously a problem.
@aentinger aentinger added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jan 14, 2022
@aentinger aentinger requested a review from facchinm January 14, 2022 10:03
@aentinger aentinger self-assigned this Jan 14, 2022
@github-actions
Copy link

Memory usage change @ e2f96f2

Board flash % RAM for global variables %
arduino:mbed_nano:nanorp2040connect 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Braccio__Template
flash		 % examples/Braccio__Template
RAM for global variables		 % examples/Braccio_factory_setID_interactive
flash		 % examples/Braccio_factory_setID_interactive
RAM for global variables		 % examples/LCD_Custom_Menu
flash		 % examples/LCD_Custom_Menu
RAM for global variables		 % examples/LCD_Menu_Joystick
flash		 % examples/LCD_Menu_Joystick
RAM for global variables		 % examples/LCD_Motors
flash		 % examples/LCD_Motors
RAM for global variables		 % examples/LearnByDoing
flash		 % examples/LearnByDoing
RAM for global variables		 % examples/New_APIs
flash		 % examples/New_APIs
RAM for global variables		 % examples/Tools/Test_Inputs
flash		 % examples/Tools/Test_Inputs
RAM for global variables		 % examples/Tools/Test_Motor_Angular_Control
flash		 % examples/Tools/Test_Motor_Angular_Control
RAM for global variables		 % examples/Tools/Test_Motor_Communication
flash		 % examples/Tools/Test_Motor_Communication
RAM for global variables		 %
arduino:mbed_nano:nanorp2040connect 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/Braccio__Template<br>flash,%,examples/Braccio__Template<br>RAM for global variables,%,examples/Braccio_factory_setID_interactive<br>flash,%,examples/Braccio_factory_setID_interactive<br>RAM for global variables,%,examples/LCD_Custom_Menu<br>flash,%,examples/LCD_Custom_Menu<br>RAM for global variables,%,examples/LCD_Menu_Joystick<br>flash,%,examples/LCD_Menu_Joystick<br>RAM for global variables,%,examples/LCD_Motors<br>flash,%,examples/LCD_Motors<br>RAM for global variables,%,examples/LearnByDoing<br>flash,%,examples/LearnByDoing<br>RAM for global variables,%,examples/New_APIs<br>flash,%,examples/New_APIs<br>RAM for global variables,%,examples/Tools/Test_Inputs<br>flash,%,examples/Tools/Test_Inputs<br>RAM for global variables,%,examples/Tools/Test_Motor_Angular_Control<br>flash,%,examples/Tools/Test_Motor_Angular_Control<br>RAM for global variables,%,examples/Tools/Test_Motor_Communication<br>flash,%,examples/Tools/Test_Motor_Communication<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@github-actions
Copy link

Memory usage change @ 6e00d45

Board flash % RAM for global variables %
arduino:mbed_nano:nanorp2040connect 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Braccio__Template
flash		 % examples/Braccio__Template
RAM for global variables		 % examples/Braccio_factory_setID_interactive
flash		 % examples/Braccio_factory_setID_interactive
RAM for global variables		 % examples/LCD_Custom_Menu
flash		 % examples/LCD_Custom_Menu
RAM for global variables		 % examples/LCD_Menu_Joystick
flash		 % examples/LCD_Menu_Joystick
RAM for global variables		 % examples/LCD_Motors
flash		 % examples/LCD_Motors
RAM for global variables		 % examples/LearnByDoing
flash		 % examples/LearnByDoing
RAM for global variables		 % examples/New_APIs
flash		 % examples/New_APIs
RAM for global variables		 % examples/Tools/Test_Inputs
flash		 % examples/Tools/Test_Inputs
RAM for global variables		 % examples/Tools/Test_Motor_Angular_Control
flash		 % examples/Tools/Test_Motor_Angular_Control
RAM for global variables		 % examples/Tools/Test_Motor_Communication
flash		 % examples/Tools/Test_Motor_Communication
RAM for global variables		 %
arduino:mbed_nano:nanorp2040connect 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/Braccio__Template<br>flash,%,examples/Braccio__Template<br>RAM for global variables,%,examples/Braccio_factory_setID_interactive<br>flash,%,examples/Braccio_factory_setID_interactive<br>RAM for global variables,%,examples/LCD_Custom_Menu<br>flash,%,examples/LCD_Custom_Menu<br>RAM for global variables,%,examples/LCD_Menu_Joystick<br>flash,%,examples/LCD_Menu_Joystick<br>RAM for global variables,%,examples/LCD_Motors<br>flash,%,examples/LCD_Motors<br>RAM for global variables,%,examples/LearnByDoing<br>flash,%,examples/LearnByDoing<br>RAM for global variables,%,examples/New_APIs<br>flash,%,examples/New_APIs<br>RAM for global variables,%,examples/Tools/Test_Inputs<br>flash,%,examples/Tools/Test_Inputs<br>RAM for global variables,%,examples/Tools/Test_Motor_Angular_Control<br>flash,%,examples/Tools/Test_Motor_Angular_Control<br>RAM for global variables,%,examples/Tools/Test_Motor_Communication<br>flash,%,examples/Tools/Test_Motor_Communication<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@aentinger aentinger merged commit 0f3d34c into master Jan 17, 2022
@aentinger aentinger deleted the fix-wrong-id-limit branch January 17, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchinm facchinm Awaiting requested review from facchinm

Assignees

@aentinger aentinger

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aentinger